LI module: Use matcher instead of source for eid premission#4487
Merged
Conversation
CTMBNara
requested changes
May 17, 2026
Comment on lines
+229
to
+230
| final List<ExtRequestPrebidDataEidPermissions> modifiedEidPermissions = CollectionUtils | ||
| .isEmpty(eidPermissions) |
| .build()) | ||
| .toList(); | ||
| private List<ExtRequestPrebidDataEidPermissions> createEidPermissions() { | ||
| return List.of(ExtRequestPrebidDataEidPermissions.builder() |
Collaborator
There was a problem hiding this comment.
List.of -> Collections.singletonList
CTMBNara
previously approved these changes
May 19, 2026
Contributor
Author
Thanks! |
Collaborator
|
Hi @peixunzhang, Danylo made a good point, build is currently broken. Could you fix the checkstyle? |
Contributor
Author
sure, i will fix it i fixed the indent, please check~ |
Use matcher to determine when to apply EID permissions, instead of source names, to avoid collisions with unrelated traffic and ensure we only permission IDs we enrich.:
Collaborator
|
Contributor
Author
hiii @osulzhenko, I fixed the formatting. Could you run the CI again? Thank you! |
Collaborator
|
@peixunzhang some tests failed. You can reproduce the CI results locally with this command: |
Contributor
Author
got it! I will take a look. Thanks~~ |
Lightwood13
approved these changes
May 26, 2026
CTMBNara
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
Use matcher to determine when to apply EID permissions, instead of source names, to avoid collisions with unrelated traffic and ensure we only permission IDs we enrich.
🏎 Quality check